codegen should error on unknown XML attributes in tags

[ab9rf]

I recently typoed typename for type-name in a structure definition. codegen silently accepted this erroneous definition instead of warning or erroring.

[lethosor]

Echoing Discord: this is hard because

• we don't have an exhaustive list of allowed attributes in codegen already
• some attributes have defaults (whether they should is another matter...)

maybe the answer is to do schema validation before ingesting files, if we can do that easily from perl.

[quietust]

The xmllint tool appears to be capable of catching those errors - whenever I do structure updates, I run this script to verify them first:

#!/bin/sh
xmllint --schema data-definition.xsd --noout df.*.xml 2>&1 | grep -v validates
./codegen.pl
git status

[lethosor]

And we run that in CI:

df-structures/.github/workflows/build.yml

Line 20 in 7c4f3e3

xmllint --schema data-definition.xsd --noout df.*.xml symbols.xml 2>&1 | tee xmllint.out; status=${PIPESTATUS[0]}

[quietust]

Indeed - that's where I got it from (though I also filter out the "validates" lines so that the output is empty if there are no problems).