Hipped Roofs now work

[Beakerboy]

The US capitol has been one of the "Example" buildings since the beginning, however, the hipped rooks have always been flat. they are now hipped as they should be.
https://beakerboy.github.io/OSMBuilding/index.html?type=relation&id=12286916

[deevroman]

For some buildings this fails
https://beakerboy.github.io/OSMBuilding/?id=88514597&type=way

Stacktrace

17:46:02.565 Error: Can't add node to closed FaceQueue
    AddPush https://cdn.skypack.dev/-/straight-skeleton@v1.1.0-yuVHIwPO9jkyjr7BklKV/dist=es2019,mode=imports/optimized/straight-skeleton.js:507
    AddPush https://cdn.skypack.dev/-/straight-skeleton@v1.1.0-yuVHIwPO9jkyjr7BklKV/dist=es2019,mode=imports/optimized/straight-skeleton.js:825
    AddFaceRight https://cdn.skypack.dev/-/straight-skeleton@v1.1.0-yuVHIwPO9jkyjr7BklKV/dist=es2019,mode=imports/optimized/straight-skeleton.js:1758
    MultiEdgeEvent https://cdn.skypack.dev/-/straight-skeleton@v1.1.0-yuVHIwPO9jkyjr7BklKV/dist=es2019,mode=imports/optimized/straight-skeleton.js:1193
    Build https://cdn.skypack.dev/-/straight-skeleton@v1.1.0-yuVHIwPO9jkyjr7BklKV/dist=es2019,mode=imports/optimized/straight-skeleton.js:1149
    BuildFromGeoJSON https://cdn.skypack.dev/-/straight-skeleton@v1.1.0-yuVHIwPO9jkyjr7BklKV/dist=es2019,mode=imports/optimized/straight-skeleton.js:1101
    HippedGeometry https://beakerboy.github.io/Threejs-Geometries/src/HippedGeometry.js:85
    createRoof https://beakerboy.github.io/OSMBuilding/src/buildingpart.js:297
    render https://beakerboy.github.io/OSMBuilding/src/buildingpart.js:194
    render https://beakerboy.github.io/OSMBuilding/src/building.js:184
    init https://beakerboy.github.io/OSMBuilding/src/index.js:62
    promise callback*init https://beakerboy.github.io/OSMBuilding/src/index.js:56
    <anonymous> https://beakerboy.github.io/OSMBuilding/src/index.js:205
index.js:234:13

[Beakerboy]

I guess should have put "work" in air-quotes. That building looks really straightforward. I'll have to troubleshoot it. There is a version 2 of the straight-skeleton library that might work with this example out of the box.

[Beakerboy]

https://github.com/Beakerboy/OSMBuilding/tree/Hipped-Roof-Expection

Here's a branch where I'm troubleshooting that bug. I'm guessing it's a bug in the library, but I should be able to at least produce a minimum test to report to the developed of that library. Unfortunately, I use a typescript library, which was translated from a C# library, which itself was translated from a Java library, so each step may have introduced some weird behaviors.