[PWGEM] Add seperate event selection for photons and event-norm table #33918
jokonigAnnotations
10 errors, 1 warning, and 2 notices
|
[magic-number]:
PWGEM/PhotonMeson/TableProducer/associateMCinfoPhoton.cxx#L328
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
[name/o2-workflow]:
PWGEM/PhotonMeson/TableProducer/CMakeLists.txt#L1
Use kebab-case for names of workflows and match the name of the workflow file.
|
|
[name/o2-workflow]:
PWGEM/PhotonMeson/TableProducer/CMakeLists.txt#L64
Workflow name event-selection-photon does not match its file name eventSelection.cxx. (Matches eventSelectionPhoton.cxx.)
|
|
[name/o2-workflow]:
PWGEM/PhotonMeson/TableProducer/CMakeLists.txt#L44
Workflow name skimmer-primary-electron-from-dalitzee does not match its file name skimmerPrimaryElectronFromDalitzEE.cxx. (Matches skimmerPrimaryElectronFromDalitzee.cxx.)
|
|
[name/o2-workflow]:
PWGEM/PhotonMeson/TableProducer/CMakeLists.txt#L39
Workflow name skimmer-phos does not match its file name skimmerPHOS.cxx. (Matches skimmerPhos.cxx.)
|
|
[name/o2-workflow]:
PWGEM/PhotonMeson/TableProducer/CMakeLists.txt#L24
Workflow name associate-mc-info-photon does not match its file name associateMCinfoPhoton.cxx. (Matches associateMcInfoPhoton.cxx.)
|
|
[name/o2-workflow]:
PWGEM/PhotonMeson/TableProducer/CMakeLists.txt#L19
Workflow name create-emevent-photon does not match its file name createEMEventPhoton.cxx. (Matches createEmeventPhoton.cxx.)
|
|
[name/o2-workflow]:
PWGEM/PhotonMeson/TableProducer/CMakeLists.txt#L14
Workflow name photon-conversion-builder does not match its file name photonconversionbuilder.cxx. (Matches photonConversionBuilder.cxx.)
|
|
[name/o2-column]:
PWGEM/PhotonMeson/DataModel/EventTables.h#L103
Use UpperCamelCase for names of O2 columns and matching lowerCamelCase names for their getters.
|
|
[name/o2-column]:
PWGEM/PhotonMeson/DataModel/EventTables.h#L93
Use UpperCamelCase for names of O2 columns and matching lowerCamelCase names for their getters.
|
|
O2 linter
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: thollander/actions-comment-pull-request@v3. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
O2 linter
To tolerate certain issues in a directory, add a line with the test name in "o2linter_config".
|
|
O2 linter
Exceptionally, you can disable a test for a line by adding a comment with "o2-linter: disable=" followed by the name of the test and parentheses with a reason for the exception.
|